cshannon commented on code in PR #5187: URL: https://github.com/apache/accumulo/pull/5187#discussion_r1910311570
########## core/src/main/java/org/apache/accumulo/core/client/admin/TabletMergeability.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.client.admin; + +import java.io.Serializable; +import java.time.Duration; +import java.util.Objects; + +import com.google.common.base.Preconditions; + +public class TabletMergeability implements Serializable { + private static final long serialVersionUID = 1L; + + public static final TabletMergeability NEVER = new TabletMergeability(Duration.ofNanos(-1)); + public static final TabletMergeability NOW = new TabletMergeability(Duration.ZERO); + + private final Duration delay; + + private TabletMergeability(Duration delay) { + this.delay = Objects.requireNonNull(delay); + } + + public boolean isNever() { + return this.delay.isNegative(); + } + + public boolean isNow() { + return this.delay.isZero(); + } + + public boolean isFuture() { Review Comment: I think isDelayed() is probably better and will rename it. I kept going back and forth with trying to decide on the correct names and I think this may change anyways. I've been wondering if instead of `NOW` it should be `ALWAYS` as ALWAYS aligns better with NEVER. I will probably leave the name alone for now because I think the exact naming is going to be how we intent to use this going forward and if we want to rename it and TabletMergeability itself could possibly be renamed in a future PR. Right now the name is TabletMereability but as @ctubbsii had pointed out in a previous conversation, the current goal for this is really tablet _automatic_ mergeability so we can use it to determine if we can run an automatic merge on a tablet range just like we do automatic splits. However, there has been some talk of making it more generic to mergeabilty in general (Even regular user triggered merges) but not sure we will or need to. Either way, I expect in future PRs as this evolves the naming is going to be tweaked a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
