kevinrr888 opened a new pull request, #5263: URL: https://github.com/apache/accumulo/pull/5263
Adds some missing FATE functionality - Previously, if a user configured fewer FATE threads to work on transactions (via MANAGER_FATE_THREADPOOL_SIZE property), the pool size would not actually be decreased. These changes safely stop excess workers in the case where the property value is decreased. - Added test FatePoolResizeIT (tests both META and USER transactions: MetaFatePoolResizeIT and UserFatePoolResizeIT) to ensure the pool size is correctly increased and decreased with configuration changes. - Fate.shutdown() was not waiting on termination of the fate pool watcher when needed. Added the missing wait. Another potential solution to this problem is disallowing decreasing the pool size, but I'm not sure if that's the way we want to go about this. Confirmation/changes to the thread safety of the new code would be appreciated. I would also be curious if someone had a better idea of how we can go about stopping the transaction runners. Currently just try to stop a random one each second. This is another prereq for #5130. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
