kevinrr888 commented on code in PR #5263:
URL: https://github.com/apache/accumulo/pull/5263#discussion_r1920442846
##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -425,11 +474,36 @@ public Fate(T environment, FateStore<T> store, boolean
runDeadResCleaner,
}
}
idleCountHistory.clear();
+ } else if (needed < 0) {
+ // If we need the pool to shrink, then ensure excess
TransactionRunners are safely stopped.
Review Comment:
This is a great solution. Implemented in newest commit. Was originally
worried about any one TransactionRunner taking too long to stop (the
transaction it's working on takes a while) when there may be other
TransactionRunners that can more easily be stopped. However, we can use the
delay between executions of the fate pool watcher as our "wait" which I didn't
consider. Eventually the correct number of TransactionRunners will be stopped
which seems sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
