kevinrr888 commented on code in PR #5273:
URL: https://github.com/apache/accumulo/pull/5273#discussion_r1920727542
##########
core/src/main/java/org/apache/accumulo/core/fate/user/schema/FateSchema.java:
##########
@@ -44,7 +44,7 @@ public static class TxInfoColumnFamily {
public static final String STR_NAME = "txinfo";
public static final Text NAME = new Text(STR_NAME);
- public static final String TX_NAME = "txname";
+ public static final String TX_NAME = "FateOp";
Review Comment:
```suggestion
public static final String FATE_OP = "fateop";
```
Would be nice to change TX_NAME here to FATE_OP and maintain lowercase
string value for consistency
##########
core/src/main/java/org/apache/accumulo/core/fate/AdminUtil.java:
##########
@@ -74,20 +74,20 @@ public static class TransactionStatus {
private final FateId fateId;
private final FateInstanceType instanceType;
private final TStatus status;
- private final Fate.FateOperation txName;
+ private final Fate.FateOperation FateOp;
Review Comment:
Commenting once but applies other places: should maintain camel case for
vars. `FateOp` -> `fateOp` would be good
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/MetaFateStore.java:
##########
@@ -223,7 +223,7 @@ private void seedTransaction(Fate.FateOperation txName,
Repo<T> repo, boolean au
if (autoCleanUp) {
txStore.setTransactionInfo(TxInfo.AUTO_CLEAN, autoCleanUp);
}
- txStore.setTransactionInfo(TxInfo.TX_NAME, txName);
+ txStore.setTransactionInfo(TxInfo.TX_NAME, FateOp);
Review Comment:
The TxInfo enum value TX_NAME should also be changed to FATE_OP
##########
core/src/main/java/org/apache/accumulo/core/fate/user/schema/FateSchema.java:
##########
@@ -44,7 +44,7 @@ public static class TxInfoColumnFamily {
public static final String STR_NAME = "txinfo";
public static final Text NAME = new Text(STR_NAME);
- public static final String TX_NAME = "txname";
+ public static final String TX_NAME = "FateOp";
public static final ColumnFQ TX_NAME_COLUMN = new ColumnFQ(NAME, new
Text(TX_NAME));
Review Comment:
This would also need to be changed to no longer reference TX_NAME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
