kevinrr888 commented on code in PR #5273:
URL: https://github.com/apache/accumulo/pull/5273#discussion_r1923827817
##########
server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java:
##########
@@ -103,8 +103,8 @@ public long getRunning() {
return running;
}
- public String getTxName() {
- return txName;
+ public String getfateOp() {
Review Comment:
```suggestion
public String getFateOp() {
```
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/MetaFateStore.java:
##########
@@ -223,7 +223,7 @@ private void seedTransaction(Fate.FateOperation txName,
Repo<T> repo, boolean au
if (autoCleanUp) {
txStore.setTransactionInfo(TxInfo.AUTO_CLEAN, autoCleanUp);
}
- txStore.setTransactionInfo(TxInfo.TX_NAME, txName);
+ txStore.setTransactionInfo(TxInfo.TX_NAME, fateOp);
Review Comment:
ensure that TxInfo.TX_NAME is no longer referenced as it no longer exists.
This, any maybe elsewhere, needs to be changed to
`TxInfo.FATE_OP`
##########
server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java:
##########
@@ -73,8 +73,8 @@ public FateTxnDetails(final long reportTime, final
AdminUtil.TransactionStatus t
if (txnStatus.getTop() != null) {
step = txnStatus.getTop();
}
- if (txnStatus.getTxName() != null) {
- txName = txnStatus.getTxName().name();
+ if (txnStatus.getfateOp() != null) {
+ fateOp= txnStatus.getfateOp().name();
Review Comment:
Run the maven command:
`mvn clean package -DskipTests`
to quickly format the project
##########
core/src/main/java/org/apache/accumulo/core/fate/user/schema/FateSchema.java:
##########
@@ -44,8 +44,8 @@ public static class TxInfoColumnFamily {
public static final String STR_NAME = "txinfo";
public static final Text NAME = new Text(STR_NAME);
- public static final String TX_NAME = "txname";
- public static final ColumnFQ TX_NAME_COLUMN = new ColumnFQ(NAME, new
Text(TX_NAME));
+ public static final String FATE_OP = "fateOp";
+ public static final ColumnFQ TX_NAME_COLUMN = new ColumnFQ(NAME, new
Text(FATE_OP));
Review Comment:
this still needs to be changed
```suggestion
public static final ColumnFQ FATE_OP_COLUMN = new ColumnFQ(NAME, new
Text(FATE_OP));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
