dlmarion commented on code in PR #5012:
URL: https://github.com/apache/accumulo/pull/5012#discussion_r1927004876


##########
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java:
##########
@@ -359,6 +366,7 @@ public void run() {
         server = new EmbeddedWebServer(this, port);
         server.addServlet(getDefaultServlet(), "/resources/*");
         server.addServlet(getRestServlet(), "/rest/*");
+        server.addServlet(getRestV2Servlet(), "/rest-v2/*");

Review Comment:
   I purposely kept the old and new REST code separate so that it makes it easy 
to identify and remove the unused code when the Monitor changes are complete. 
So, I agree with your suggestions here about the naming of the rest endpoint, 
servlet, etc., but I think these changes should be made later in another PR 
where we are removing all of the code in the current 
org.apache.accumulo.monitor.rest package and subpackages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to