keith-turner commented on code in PR #5277:
URL: https://github.com/apache/accumulo/pull/5277#discussion_r1927649064
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/PreUpgradeValidation.java:
##########
@@ -54,7 +64,14 @@ public void validate(final ServerContext context, final
EventCoordinator eventCo
log.debug("already at current data version: {}, skipping validation",
cv);
return;
}
- validateACLs(context);
+
+ try {
+ validateACLs(context);
+ abortIfFateTransactions(context);
+ validateProperties(context);
Review Comment:
Sometimes the upgrade zookeeper code deletes properties, like the
Upgrader10to11 code seems to delete replication properties. Also in the past
the upgrade zookeeper code translated the persisted format of config in
zookeeper. These two behaviors can make validating prior to upgrading
zookeeper tricky. However failing on property validation after upgrading
zookeeper is no good either. Not sure how to improve this though, but it seems
like a potential problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
