ddanielr commented on code in PR #5277:
URL: https://github.com/apache/accumulo/pull/5277#discussion_r1927804330
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/PreUpgradeValidation.java:
##########
@@ -54,7 +64,14 @@ public void validate(final ServerContext context, final
EventCoordinator eventCo
log.debug("already at current data version: {}, skipping validation",
cv);
return;
}
- validateACLs(context);
+
+ try {
+ validateACLs(context);
+ abortIfFateTransactions(context);
+ validateProperties(context);
Review Comment:
Yeah I agree that can be a problem. #5279 was created to help address
validating the state of the system prior to an upgrade.
At a minimum, it sounds like we want the property validation to stay in the
`upgradeMetadata` method.
https://github.com/apache/accumulo/blob/main/server/manager/src/main/java/org/apache/accumulo/manager/Manager.java#L334-L344
I'll look into what the property validate code actually does for validation.
It might be doing less than we think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
