keith-turner commented on code in PR #5312:
URL: https://github.com/apache/accumulo/pull/5312#discussion_r1945534911
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java:
##########
@@ -338,7 +338,10 @@ public static List<KeyExtent>
findOverlappingTablets(Function<Text,KeyExtent> ro
List<KeyExtent> result = new ArrayList<>();
Text row = new Text();
+ long iterationCount = 0;
while (true) {
+ iterationCount++;
+
Review Comment:
I believe this code is ok, it jump around in the metadata table and does not
scan over tablets it does not need to.
The code that does scan over tablets in the metadata table is
[here](https://github.com/apache/accumulo/blob/4761d5a7e65873a2a52d04654de71335c3ad5e27/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java#L375-L377)
. Would be good to track counts of skipped vs total tablets in that code. The
function is called multiple times for a single bulk load and could get the
counts from all calls and log after that loop that calls the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
