ddanielr commented on code in PR #5312:
URL: https://github.com/apache/accumulo/pull/5312#discussion_r1970134420
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -371,11 +374,17 @@ private List<TabletMetadata>
findOverlappingTablets(KeyExtent loadRange,
int cmp;
+ long wastedIterations = 0;
Review Comment:
`findOverlappingTablets` is called multiple times inside of `loadFiles`. We
should aggregate these wasted iterations and wasted time trackers and display
the totals at the end of the `loadFiles` method.
With the recent fate timing changes added in #5354 we can get a clearer
picture of how this code is performing
https://github.com/apache/accumulo/blob/aa7944b621ffc669917e2a30cd4c163bee760b48/core/src/main/java/org/apache/accumulo/core/fate/Fate.java#L226-L227
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -371,11 +374,17 @@ private List<TabletMetadata>
findOverlappingTablets(KeyExtent loadRange,
int cmp;
+ long wastedIterations = 0;
+ Timer timer = Timer.startNew();
+
// skip tablets until we find the prevEndRow of loadRange
while ((cmp = PREV_COMP.compare(currTablet.getPrevEndRow(),
loadRange.prevEndRow())) < 0) {
+ wastedIterations++;
currTablet = tabletIter.next();
}
+ long wastedMillis = timer.elapsed(MILLISECONDS);
Review Comment:
Track this as nanos to allow for aggregation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
