ddanielr commented on code in PR #5321:
URL: https://github.com/apache/accumulo/pull/5321#discussion_r1962293501


##########
assemble/bin/accumulo-cluster:
##########
@@ -520,6 +533,13 @@ function control_services() {
           execute_command "$operation" "$sserver" sserver "$group" "-o" 
"sserver.group=$group"
         fi
       done
+      if [[ $operation == "stop" || $operation == "kill" ]]; then
+        # If the prior commands were executed via ssh, then we need to wait 
for them
+        # to complete before zapping the nodes in ZooKeeper
+        ssh_wait
+        echo "Cleaning scan server entries from zookeeper for resource group 
$group"
+        debugOrRun "$accumulo_cmd" org.apache.accumulo.server.util.ZooZap 
-verbose -sservers -group "$group"

Review Comment:
   same `-local` condition handling comment



##########
assemble/bin/accumulo-cluster:
##########
@@ -538,14 +558,19 @@ function control_services() {
           execute_command "$operation" "$compactor" compactor "$group" "-o" 
"compactor.group=$group"
         fi
       done
+      if [[ $operation == "stop" || $operation == "kill" ]]; then
+        # If the prior commands were executed via ssh, then we need to wait 
for them
+        # to complete before zapping the nodes in ZooKeeper
+        ssh_wait
+        echo "Cleaning compactor entries from zookeeper for resource group 
$group"
+        debugOrRun "$accumulo_cmd" org.apache.accumulo.server.util.ZooZap 
-verbose -compactors -group "$group"

Review Comment:
   same `-local` condition handling comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to