ctubbsii commented on PR #5321: URL: https://github.com/apache/accumulo/pull/5321#issuecomment-2672425149
> [e5d7224](https://github.com/apache/accumulo/commit/e5d7224495bf610fd75f31c4377755c6350c73f5) introduces a mechanism that will wait for all of the ssh commands to finish before calling ZooZap. The `shellcheck` GitHub action is failing with the following: > > ``` > ^-- SC2009 (info): Consider using pgrep instead of grepping ps output. > ``` > > I'm thinking I should just suppress this. I'm not sure if `pgrep` is installed by default on all operating systems. procps-ng, which ships pgrep and pkill, is a dependency of plymouth for graphical boot, so it can be presumed to be installed on workstations. It might not be installed on a minimal server install, but it's also a dependency of initscripts, so it can be presumed to be installed by default on Fedora/RHEL/CentOS and derivatives. 3.3.15 and earlier of procps-ng has a bug where it can't find commands whose length exceeds 4096 (which includes ZooKeeper). See https://bugzilla.redhat.com/show_bug.cgi?id=1782309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
