keith-turner commented on PR #5301:
URL: https://github.com/apache/accumulo/pull/5301#issuecomment-2725561351

   > Perhaps we should create a sunny day test which tests fate operations on 
Accumulo system tables or maybe this would be caught in the full build and that 
is sufficient (I have not run the full build to see if that's true).
   
   It does not have to be sunny day test, but we should probably have ITs that 
execute every table opertion against the system tables to ensure they behave as 
expected.  Would need to survey and see what coverage we currently have for 
this, I know there is some but not sure its complete.  Not something for this 
PR.
   
   > @keith-turner - Could you take a look at these changes? Most of the 
changes to Fate and FateExecutor were copy-paste so those can be ignored. 
Mostly curious what you think about the changes to Property and the new test.
   
   @kevinrr888 I looked over the changes and they look good. I made one comment 
about a possible improvement to the test that would be nice if its workable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to