kevinrr888 commented on PR #5301:
URL: https://github.com/apache/accumulo/pull/5301#issuecomment-2748912678

   @keith-turner
   > I made one comment about a possible improvement to the test that would be 
nice if its workable.
   
   That is a nice additional check. I added it throughout the tests where 
applicable. 
   
   I also merged main into this branch. The only thing noteworthy of that is 
the new `SYSTEM_MERGE` operation that was recently added. In the default value 
of the new properties, I added this as shown for the config for `META` and 
`USER`:
   ```
            
"{\"TABLE_CREATE,TABLE_DELETE,TABLE_RENAME,TABLE_ONLINE,TABLE_OFFLINE,NAMESPACE_CREATE,"
             + 
"NAMESPACE_DELETE,NAMESPACE_RENAME,TABLE_TABLET_AVAILABILITY,SHUTDOWN_TSERVER,"
             + 
"TABLE_BULK_IMPORT2,TABLE_COMPACT,TABLE_CANCEL_COMPACT,TABLE_MERGE,TABLE_DELETE_RANGE,"
             + 
"TABLE_SPLIT,TABLE_CLONE,TABLE_IMPORT,TABLE_EXPORT,SYSTEM_MERGE\": 4,"
             + "\"COMMIT_COMPACTION\": 4,\"SYSTEM_SPLIT\": 4}"
   ```
   If we find that `SYSTEM_MERGE` (or any of the ops) need more resources, we 
can change this default.
   
   > It does not have to be sunny day test, but we should probably have ITs 
that execute every table opertion against the system tables to ensure they 
behave as expected. Would need to survey and see what coverage we currently 
have for this, I know there is some but not sure its complete. Not something 
for this PR.
   
   I'll open an issue for this
   
   Merging this into main now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to