DomGarguilo commented on PR #5398: URL: https://github.com/apache/accumulo/pull/5398#issuecomment-2730909643
Marking this as ready for review. I tried to address the following two suggestions from the ticket: > 1. Primarily, create a custom protocol with the versioning information stored in a header and checks on the server side to validate it, then > 2. Secondarily, simplify the thrift APIs by adding tracing info to the protocol header There are a lot of changed files in this PR since I had to update the thrift code. There are also a lot of places where the only change is the removal of the `TInfo` object as the first param in a method call which was a trivial change. Hopefully that helps skip/skim over portions of the diff while reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
