DomGarguilo commented on PR #5398:
URL: https://github.com/apache/accumulo/pull/5398#issuecomment-2762158793

   @kevinrr888 your suggestions should all be addressed as of 29c1234
   
   in that commit I...
   * refactored the protocol version compatibility check method to throw an 
exception directly instead of return a boolean. I also updated the wording on 
that message to make things more clear
   * addressed the IDE warnings regarding nullness in various places
   * added javadoc to the static client and server factory methods in 
ThriftUtil to make it clearer which should be used


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to