dlmarion commented on code in PR #5419:
URL: https://github.com/apache/accumulo/pull/5419#discussion_r2004398454
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1146,14 +1139,9 @@ public void run() {
managerClientHandler = new ManagerClientServiceHandler(this);
compactionCoordinator = new CompactionCoordinator(context, security,
fateRefs, this);
- // Start the Manager's Client service
- // Ensure that calls before the manager gets the lock fail
- ManagerClientService.Iface haProxy =
- HighlyAvailableServiceWrapper.service(managerClientHandler, this);
Review Comment:
@keith-turner - I think I see what you are saying, that a client that
already has the address could communicate with Manager 2 as soon as the Thrift
server starts, but before Manager2 is fully up. I don't know of anything in the
codebase that would prevent this from happening, except for the HA code I
removed in this PR or the alternate TMultiplexedProcessor I put in the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
