ctubbsii commented on code in PR #5419:
URL: https://github.com/apache/accumulo/pull/5419#discussion_r2004476451
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1146,14 +1139,9 @@ public void run() {
managerClientHandler = new ManagerClientServiceHandler(this);
compactionCoordinator = new CompactionCoordinator(context, security,
fateRefs, this);
- // Start the Manager's Client service
- // Ensure that calls before the manager gets the lock fail
- ManagerClientService.Iface haProxy =
- HighlyAvailableServiceWrapper.service(managerClientHandler, this);
Review Comment:
Even if we have nothing to prevent this, I still don't know what this would
be protecting. Just as an example, let's say I call waitForFateOperation... do
I really care that it's the second manager that tells me the fate operation
finished? As long as it has the lock, it should be okay that it is the one that
answered. I'm not sure why we would want it to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
