ctubbsii commented on code in PR #5438:
URL: https://github.com/apache/accumulo/pull/5438#discussion_r2029295071


##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -68,6 +69,18 @@ protected AbstractServer(String appName, ServerOpts opts, 
String[] args) {
     var siteConfig = opts.getSiteConfiguration();
     SecurityUtil.serverLogin(siteConfig);
     context = new ServerContext(siteConfig);
+    final String upgradePrepNode = context.getZooKeeperRoot() + 
Constants.ZPREPARE_FOR_UPGRADE;

Review Comment:
   I was kind of thinking it would hold the user's intent. Presumably, the user 
knows what version they want to upgrade to, and could specify, and then we can 
validate that during the upgrade, and stop if we are not the version the user 
wanted to upgrade to.
   
   Alternatively, we can just store the current version, and use it for the 
error message.
   
   I'm not sure we need either of these. Just kinda thinking about what we 
could do with this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to