dlmarion commented on code in PR #5438:
URL: https://github.com/apache/accumulo/pull/5438#discussion_r2029120606


##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -68,6 +69,18 @@ protected AbstractServer(String appName, ServerOpts opts, 
String[] args) {
     var siteConfig = opts.getSiteConfiguration();
     SecurityUtil.serverLogin(siteConfig);
     context = new ServerContext(siteConfig);
+    final String upgradePrepNode = context.getZooKeeperRoot() + 
Constants.ZPREPARE_FOR_UPGRADE;

Review Comment:
   The UpgradeCoordinator code doesn't have any notion of the software version 
that I'm aware of. It just has the AccumuloDataVersion, which is a whole number 
that is incremented. Also, there would be no way to validate the input of a new 
version number in the old version of software. Accumulo version 2.1.4 has no 
idea whether 4.0 is valid (It's not is should be 4.0.0). I'm not sure how we 
would make this work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to