ctubbsii commented on code in PR #5439:
URL: https://github.com/apache/accumulo/pull/5439#discussion_r2032038370
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -88,15 +88,17 @@ static class Opts extends Help {
boolean zapCompactors = false;
@Parameter(names = "-sservers", description = "remove scan server locks")
boolean zapScanServers = false;
+ @Parameter(names = "-gc", description = "remove gc server locks")
+ boolean zapGc = false;
+ @Parameter(names = "-monitor", description = "remove monitor server locks")
+ boolean zapMonitor = false;
Review Comment:
We really need to stop using single dash for options. This is the only
utility that does that, and it's not the normal convention, which can lead to
confusion. It would be better to use double dash for new options, and to fix
the other ones. This is not a utility we typically expect a user to call
directly, so the risk of changing it to conform to norms is low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
