keith-turner commented on code in PR #5439:
URL: https://github.com/apache/accumulo/pull/5439#discussion_r2032065103
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -88,15 +88,17 @@ static class Opts extends Help {
boolean zapCompactors = false;
@Parameter(names = "-sservers", description = "remove scan server locks")
boolean zapScanServers = false;
+ @Parameter(names = "-gc", description = "remove gc server locks")
+ boolean zapGc = false;
+ @Parameter(names = "-monitor", description = "remove monitor server locks")
+ boolean zapMonitor = false;
Review Comment:
For the new options I can use double dash.
For the existing options maybe we could define them like `@Parameter(names =
{"-tservers", "--tservers"}` in 2.1 and then drop the single dash option later.
When adding the double dash option may also be an opportunity to make some of
the terminology used more consistent w/ the scripts. That could be done in a
follow on PR, would add noise to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
