kevinrr888 commented on code in PR #5510:
URL: https://github.com/apache/accumulo/pull/5510#discussion_r2063728749
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -2243,7 +2241,6 @@ private void validatePropertiesToSet(Map<String,String>
opts, Map<String,String>
public void setTabletAvailability(String tableName, Range range,
TabletAvailability availability)
throws AccumuloSecurityException, AccumuloException {
EXISTING_TABLE_NAME.validate(tableName);
- NOT_BUILTIN_TABLE.validate(tableName);
Review Comment:
I don't think we would want to catch a IAE then immediately throw AE
throughout `TableOperations`
I think we should just make a decision:
1) This approach avoids RPC when the given table is not valid/not correct
format AND when the op cannot be performed on the table based on name alone
`IllegalArgumentException` - The table does not make sense (given table is
not valid/not correct format, operation cannot be performed on the given table
based on name alone)
`AccumuloException` - other issues
2) This approach avoids RPC when the given table is not valid/not correct
format
`IllegalArgumentException` - The table does not make sense (given table is
not valid/not correct format)
`AccumuloException` - operation cannot be performed on the given table based
on name alone... other issues
And document this. Many of the table operations don't have an explanation
for the exceptions thrown and what they mean, so this could be done when adding
more documentation if that is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
