kevinrr888 commented on code in PR #5510:
URL: https://github.com/apache/accumulo/pull/5510#discussion_r2063783714


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -2243,7 +2241,6 @@ private void validatePropertiesToSet(Map<String,String> 
opts, Map<String,String>
   public void setTabletAvailability(String tableName, Range range, 
TabletAvailability availability)
       throws AccumuloSecurityException, AccumuloException {
     EXISTING_TABLE_NAME.validate(tableName);
-    NOT_BUILTIN_TABLE.validate(tableName);

Review Comment:
   I don't think we would want to catch a IAE then immediately throw AE 
throughout `TableOperations`
   
   I would prefer to keep it consistent everywhere. This single method is the 
only one not consistent with the rest, and I don't think it was intentional.
   
   If we want to go with checking for BUILTIN_TABLE, METADATA_TABLE, or 
ROOT_TABLE on the client side, maybe that could be it's own PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to