keith-turner commented on PR #5550: URL: https://github.com/apache/accumulo/pull/5550#issuecomment-2898298167
> It appears that based on the referenced Thrift code, if the incoming frame is less than the max frame size, but reading the frame would use more memory than the total, it returns true (for the connection to remain alive) and does not read the frame off the network stack. yeah that is what I suspected it was doing. It seems to read 4 bytes off the network for the frame size and then only does further reads if the frame size passes the two checks. I was thinking that these props could be set w/ like a 1M max frame size and 100M max total buffer amount. If the max frame size was set to 100M and the max total amount to buffer was set to 1M, then it could create a situation that allows the code to hang forever. Probably need to check the two property values to make sure that one is `<=` the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
