dlmarion commented on code in PR #5720:
URL: https://github.com/apache/accumulo/pull/5720#discussion_r2192387424
##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactionConfigurer.java:
##########
@@ -47,10 +49,25 @@ public interface InitParameters {
/**
* @since 2.1.0
*/
- public interface InputParameters {
+ interface InputParameters {
Review Comment:
The server code provides an implementation of these interfaces and then
calls the methods on the CompactionConfigurer interface passing the object
created on the server side. Is it the case that these interfaces
(InitParameters and InputParameters) are *not* part of the public api and can
change like this in a patch release?
##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactionConfigurer.java:
##########
@@ -34,7 +36,7 @@ public interface CompactionConfigurer {
/**
* @since 2.1.0
*/
- public interface InitParameters {
+ interface InitParameters {
Review Comment:
This class is public API. If a user has their own implementation, does
removing `public` here cause some type of runtime exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
