keith-turner commented on code in PR #5720:
URL: https://github.com/apache/accumulo/pull/5720#discussion_r2192771926


##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactionConfigurer.java:
##########
@@ -47,10 +49,25 @@ public interface InitParameters {
   /**
    * @since 2.1.0
    */
-  public interface InputParameters {
+  interface InputParameters {

Review Comment:
   These are part of the public API.  This change does violate semver.  I made 
the change because this was initially added in 2.1.0 and these methods should 
have been added then but were missed.  Also we have a few other small changes 
in 2.1.4 that violate semver.  I can get all of these semver violations 
documented in the release notes if we merge this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to