dlmarion commented on code in PR #5719:
URL: https://github.com/apache/accumulo/pull/5719#discussion_r2193435161
##########
core/src/main/java/org/apache/accumulo/core/trace/TraceUtil.java:
##########
@@ -96,7 +97,10 @@ public static Span startServerRpcSpan(Class<?> caller,
String spanName, TInfo ti
private static Span startSpan(Class<?> caller, String spanName, SpanKind
kind,
Map<String,String> attributes, TInfo tinfo) {
- if (!enabled && !Span.current().getSpanContext().isValid()) {
+ Context context = tinfo == null ? null : getContext(tinfo);
Review Comment:
I talked with @ctubbsii about this, and I think I understand the changes
more. Based on our discussion, I think the changes here enable server tracing
to occur when disabled on the server side, but requested by the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
