ctubbsii commented on PR #5719:
URL: https://github.com/apache/accumulo/pull/5719#issuecomment-3059553325

   @dlmarion and I looked at this today and found some more issues. We found 
that the utility code caches `OpenTelemetry.noop()` on the server-side if the 
`enabled` property is set to false. This prevents the client from triggering 
end-to-end tracing because the server side can't get a tracer from the NOOP 
instance. I will add his commit to this PR to fix that.
   
   We also found an error in the blog post, in that you cannot enable tracing 
in the shell using the `accumulo-client.properties` file. There is no 
client-side tracing property. The shell has TraceCommand to enable and disable 
tracing by creating a client-side span to wrap subsequent actions. I am going 
to do a little more experimentation to make sure the shell is behaving as 
intended and append any changes, if needed, to this PR as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to