ibilley7 commented on code in PR #5732:
URL: https://github.com/apache/accumulo/pull/5732#discussion_r2200807051


##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerTime.java:
##########
@@ -85,20 +85,38 @@ public class ManagerTime {
    * start.</li>
    * </ul>
    */
-  private final AtomicReference<Duration> skewAmount;
+  private AtomicReference<Duration> skewAmount;
 
-  public ManagerTime(Manager manager, AccumuloConfiguration conf) throws 
IOException {
-    this.zk = manager.getContext().getZooSession().asReaderWriter();
-    this.manager = manager;
+  ManagerTime() {
+    this.manager = new AtomicReference<>(null);
+  }
+
+  // Once it's set call constructor
+  public void setManager(Manager manager) throws IOException {

Review Comment:
   What is the time based on? It is based on when the Manager object was 
constructed? When the ManagerTime object was constructed? And is it the 
`mt.getTime()` method call that is throwing the NPE? Is that why the 
assertThrows is there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to