ibilley7 commented on code in PR #5732:
URL: https://github.com/apache/accumulo/pull/5732#discussion_r2201534983


##########
server/base/src/main/java/org/apache/accumulo/server/manager/LiveTServerSet.java:
##########
@@ -211,10 +213,23 @@ static class TServerInfo {
   // The set of entries in zookeeper without locks, and the first time each 
was noticed
   private final Map<ServiceLockPath,Long> locklessServers = new HashMap<>();
 
-  public LiveTServerSet(ServerContext context, Listener cback) {
-    this.cback = cback;
+  public LiveTServerSet(ServerContext context) {
+    this.cback = new AtomicReference<>(null);
     this.context = context;
-    this.context.getZooCache().addZooCacheWatcher(this);
+  }
+
+  public void setCback(Listener cback) {

Review Comment:
   What the mock Listener expects has to be greatly expanded upon in order to 
pass it through `startListeningForTabletServerChanges` and achieve the same 
goal of the test without getting any errors. I'm just wondering if the hassle 
is worth it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to