keith-turner commented on code in PR #5743: URL: https://github.com/apache/accumulo/pull/5743#discussion_r2214684632
########## core/src/main/java/org/apache/accumulo/core/client/admin/compaction/ErasureCodeConfigurer.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.client.admin.compaction; + +import java.util.HashMap; +import java.util.Map; + +import org.apache.accumulo.core.conf.ConfigurationTypeHelper; +import org.apache.accumulo.core.conf.Property; + +import com.google.common.base.Preconditions; + +/** + * <p> + * A compaction configurer that extends CompressionConfigurer and adds the ability to control and + * configure how Erasure Codes work. This plugin accepts the following options, when setting these + * options on a table prefix them with {@code table.compaction.configurer.opts.}. + * + * <ul> + * <li>Set {@value #ERASURE_CODE_SIZE} to a size in bytes. The suffixes K,M,and G can be used. This + * is the minimum file size to allow conversion to erasure code. If a file is below this size it + * will be replicated otherwise erasure coding will be enabled. Review Comment: Good find. Looked at the HDFS output stream builder and found that it has an option to force replication regardless of the dir settings. In af055c9 I modified the accumulo config to have three options instead of two and used this option on the builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
