keith-turner commented on code in PR #5743:
URL: https://github.com/apache/accumulo/pull/5743#discussion_r2214686563


##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java:
##########
@@ -136,10 +137,23 @@ protected FileSKVWriter openWriter(FileOptions options) 
throws IOException {
       String file = options.getFilename();
       FileSystem fs = options.getFileSystem();
 
+      boolean useEC =
+          
options.getTableConfiguration().getBoolean(Property.TABLE_ENABLE_ERASURE_CODES);
+
       if (options.dropCacheBehind) {
+
         EnumSet<CreateFlag> set = EnumSet.of(CreateFlag.SYNC_BLOCK, 
CreateFlag.CREATE);
-        outputStream = fs.create(new Path(file), FsPermission.getDefault(), 
set, bufferSize,
-            (short) rep, block, null);
+        if (useEC && (fs instanceof DistributedFileSystem)) {
+          String ecPolicyName =
+              
options.getTableConfiguration().get(Property.TABLE_ERASURE_CODE_POLICY);

Review Comment:
   Added a test in af055c9  to see what happens when an invalid policy is 
specified and a decent error message will percolate up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to