kevinrr888 commented on code in PR #5740:
URL: https://github.com/apache/accumulo/pull/5740#discussion_r2216070788
##########
core/src/test/java/org/apache/accumulo/core/metadata/schema/TabletMetadataTest.java:
##########
@@ -170,46 +202,83 @@ public void testAllColumns() {
mutation.put(ExternalCompactionColumnFamily.STR_NAME, ecid.canonical(),
ecMeta.toJson());
TServerInstance tsi = new TServerInstance("localhost:9997", 5000L);
+
MIGRATION_COLUMN.put(mutation, new Value(tsi.getHostPortSession()));
SortedMap<Key,Value> rowMap = toRowMap(mutation);
TabletMetadata tm = TabletMetadata.convertRow(rowMap.entrySet().iterator(),
EnumSet.allOf(ColumnType.class), true, false);
+ assertTrue(tm.getCompacted().isEmpty());
+ allColumns.remove(COMPACTED);
+
assertEquals(TabletMergeabilityMetadata.fromValue(mergeabilityValue).toJson(),
+
TabletMergeabilityMetadata.toValue(tm.getTabletMergeability()).toString());
Review Comment:
```suggestion
assertEquals(mergeability,
tm.getTabletMergeability());
```
Compares the objects directly instead of strings which is a bit nicer/safer.
Will have to create a TabletMergeabilityMetadata obj `mergeability`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
