keith-turner commented on code in PR #5740: URL: https://github.com/apache/accumulo/pull/5740#discussion_r2222892992
########## core/src/test/java/org/apache/accumulo/core/metadata/schema/TabletMetadataTest.java: ########## @@ -106,6 +125,8 @@ public class TabletMetadataTest { @Test public void testAllColumns() { + List<ColumnType> allColumns = new ArrayList<>(List.of(ColumnType.values())); Review Comment: Could make this a set like `Set<ColumnType> allColumns = EnumSet.allOf(ColumnType.class);` then the removals will be more efficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org