keith-turner commented on code in PR #5749:
URL: https://github.com/apache/accumulo/pull/5749#discussion_r2243160443


##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1668,6 +1668,13 @@ public static boolean isValidZooPropertyKey(String key) {
         || 
key.equals(Property.GENERAL_FILE_NAME_ALLOCATION_BATCH_SIZE_MAX.getKey());
   }
 
+  public static boolean isValidResourceGroupPropertyKey(String property) {
+    return property.startsWith(Property.GENERAL_PREFIX.getKey())

Review Comment:
   Looking through the RPC props most do seem to be more at the instance level 
and there are just a few that would make sense at the RG level.  We sohuld punt 
on this for now and maybe in a follow on we could create a new prefix like 
`rpc.tuning` or `rpc.performance` and potentially move the few props that are 
soley related to performance there.  Then we could allow that more narrow 
prefix to be set at the RG level.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to