keith-turner commented on code in PR #5749: URL: https://github.com/apache/accumulo/pull/5749#discussion_r2243179988
########## server/base/src/main/java/org/apache/accumulo/server/conf/ResourceGroupConfiguration.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.server.conf; + +import org.apache.accumulo.core.conf.Property; +import org.apache.accumulo.server.ServerContext; +import org.apache.accumulo.server.conf.store.ResourceGroupPropKey; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ResourceGroupConfiguration extends ZooBasedConfiguration { + + private static final Logger LOG = LoggerFactory.getLogger(ResourceGroupConfiguration.class); + + private final RuntimeFixedProperties runtimeFixedProps; + + public ResourceGroupConfiguration(ServerContext context, ResourceGroupPropKey rgPropKey, + SystemConfiguration parent) { + super(LOG, context, rgPropKey, parent); + runtimeFixedProps = parent.getRuntimeFixedProperties(); Review Comment: Looking at the fixed props, the ones that seem to be the most useful to set at the RG level are scan server and tablet server props. For example could adjust cache sizes or how often a scan server refreshes its metadata. Those seem useful to set at the RG level, even if it requires restarting the servers at that level. Also not seeing any that seems like they would harmful to set at the RG level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
