ctubbsii commented on code in PR #5919:
URL: https://github.com/apache/accumulo/pull/5919#discussion_r2373676743
##########
test/src/main/java/org/apache/accumulo/test/VolumeChooserIT.java:
##########
@@ -333,28 +281,38 @@ public void twoTablesDiffChoosers() throws Exception {
@Test
public void includeSpecialVolumeForTable() throws Exception {
log.info("Starting includeSpecialVolumeForTable");
+ var namespace = "ns_" + getUniqueNames(2)[1];
try (AccumuloClient client =
Accumulo.newClient().from(getClientProperties()).build()) {
// the following table will be configured to go to the excluded volume
- String configuredVolumes = v3.toString();
- configureNamespace(client, PreferredVolumeChooser.class.getName(),
configuredVolumes,
- namespace2);
- verifyVolumesForWritesToNewTable(client, namespace2, configuredVolumes);
+ configurePreferred(client, namespace, v3);
+ verifyVolumesForWritesToNewTable(client, namespace, v3.toString());
}
}
@Test
public void waLogsSentToConfiguredVolumes() throws Exception {
log.info("Starting waLogsSentToConfiguredVolumes");
+ var tableName = testName();
try (AccumuloClient client =
Accumulo.newClient().from(getClientProperties()).build()) {
- String tableName = "anotherTable";
- client.tableOperations().create(tableName);
+ client.namespaceOperations().setProperty(Namespace.DEFAULT.name(),
PREFERRED_CHOOSER_PROP,
+ systemPreferredVolumes);
+
+ createPresplitTable(client, tableName);
+ // don't flush, in order to ensure WALs exist
+ verifyTableContents(client, tableName);
- VolumeChooserIT.addSplits(client, tableName);
- VolumeChooserIT.writeDataToTable(client, tableName, alpha_rows);
// should only go to v2 as per configuration in configure()
- VolumeChooserIT.verifyWaLogVolumes(client, new Range(), v2.toString());
+ try (var scanner =
Review Comment:
Cool. I approved that one, and will rebase this after that's merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
