ctubbsii commented on PR #5919: URL: https://github.com/apache/accumulo/pull/5919#issuecomment-3331096816
> These changes are a nice improvement in the test. AFAICT the code is testing the same thing it was before the changes. Were there any change to what functionality is being tested? After rebasing, the main changes I made were to create a new test to test the default preferred volume at the system level, which I think was the whole point of the the property being set that needed fixing in #5918 . But this does it the right way. I also disabled a test that wasn't really adding any coverage... it was just testing a single table using a preferred volume. However, it looks like the original intent was to test behavior that we don't support, which is to choose a volume not in the instance.volumes. I left the test in place, but marked disabled, to document that, because it's very short. What it had ended up doing, instead of what it was supposed to be doing (which isn't supported), is already covered by the other tests that create preferred volumes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
