DomGarguilo commented on code in PR #5981:
URL: https://github.com/apache/accumulo/pull/5981#discussion_r2542823907
##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactableFile.java:
##########
@@ -48,16 +49,23 @@ public interface CompactableFile {
public long getEstimatedEntries();
+ /**
+ * Create a compactable file object that implements equals and hash code
based on the file uri and
+ * an infinite range.
+ */
static CompactableFile create(URI uri, long estimatedSize, long
estimatedEntries) {
return new CompactableFileImpl(uri, estimatedSize, estimatedEntries);
}
/**
- * Creates a new CompactableFile object that implements this interface.
+ * Creates a new CompactableFile object that implements this interface. The
returned object
+ * implements equals() and hashCode() based only on the file uri and range.
*
+ * @param range must be of the form (startRow, endRow]
* @since 4.0.0
*/
- static CompactableFile create(URI uri, Range range, long estimatedSize, long
estimatedEntries) {
- return new CompactableFileImpl(uri, range, estimatedSize,
estimatedEntries);
+ static CompactableFile create(URI uri, RowRange range, long estimatedSize,
Review Comment:
It looks like the `CompactableFileImpl` constructor used here is **only**
used in this spot. Im wondering if we could accept RowRange in that constructor
or if we want to allow for a Range there too and keep things how they are here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
