keith-turner commented on code in PR #5981:
URL: https://github.com/apache/accumulo/pull/5981#discussion_r2543501833
##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactableFile.java:
##########
@@ -48,16 +49,23 @@ public interface CompactableFile {
public long getEstimatedEntries();
+ /**
+ * Create a compactable file object that implements equals and hash code
based on the file uri and
+ * an infinite range.
+ */
static CompactableFile create(URI uri, long estimatedSize, long
estimatedEntries) {
return new CompactableFileImpl(uri, estimatedSize, estimatedEntries);
}
/**
- * Creates a new CompactableFile object that implements this interface.
+ * Creates a new CompactableFile object that implements this interface. The
returned object
+ * implements equals() and hashCode() based only on the file uri and range.
*
+ * @param range must be of the form (startRow, endRow]
* @since 4.0.0
*/
- static CompactableFile create(URI uri, Range range, long estimatedSize, long
estimatedEntries) {
- return new CompactableFileImpl(uri, range, estimatedSize,
estimatedEntries);
+ static CompactableFile create(URI uri, RowRange range, long estimatedSize,
Review Comment:
I pushed the RowRange down a bit further in d1bdb01. When doing that
noticed that CompactableFile had a getRange method, converted that to return a
RowRange. Had to write new code to go from Range to RowRange.
CompactableFileImpl wraps a StoredTableFile which uses a Range that is expected
to be a row range. May be worthwhile looking into converting that to a
RowRange in a follow on PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
