keith-turner commented on code in PR #5988:
URL: https://github.com/apache/accumulo/pull/5988#discussion_r2557763482
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1280,7 +1280,9 @@ public enum Property {
"The durability used to write to the write-ahead log. Legal values are:"
+ " none, which skips the write-ahead log; log, which sends the data
to the"
+ " write-ahead log, but does nothing to make it durable; flush,
which pushes"
- + " data to the file system; and sync, which ensures the data is
written to disk.",
+ + " data to the file system; and sync, which ensures the data is
written to disk."
Review Comment:
Re performance impact, I was wondering if there is any diff in setting sync
at file creation time vs calling hsync() immediately before closing the file.
Like does one continuously cause syncs during write vs batching them at the
end? Maybe one of the two approaches is faster or maybe there is no diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
