keith-turner commented on code in PR #99:
URL: https://github.com/apache/accumulo-access/pull/99#discussion_r2687658165
##########
core/src/main/java/org/apache/accumulo/access/impl/AccessEvaluatorImpl.java:
##########
@@ -74,7 +75,8 @@ public AccessEvaluatorImpl(Authorizations authorizations,
public static CharSequence unescape(CharSequence auth) {
int escapeCharCount = 0;
- for (int i = 0; i < auth.length(); i++) {
+ final int authLength = auth.length();
Review Comment:
It only calls it once in the code, noticed the function call is repeatedly
called at runtime for each loop iteration. That was what I was thinking of in
terms of duplication, but not sure if its worthwhile to avoid that or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
