keith-turner commented on code in PR #99:
URL: https://github.com/apache/accumulo-access/pull/99#discussion_r2696062696


##########
core/src/main/java/org/apache/accumulo/access/impl/AccessEvaluatorImpl.java:
##########
@@ -74,7 +75,8 @@ public AccessEvaluatorImpl(Authorizations authorizations,
 
   public static CharSequence unescape(CharSequence auth) {
     int escapeCharCount = 0;
-    for (int i = 0; i < auth.length(); i++) {
+    final int authLength = auth.length();

Review Comment:
   The following code is what I was thinking could benefit from the same 
changes being made elsewhere in this code.
   
   
https://github.com/apache/accumulo-access/blob/c48e0283007e727a84d717c4ec40652639a32a0b/core/src/main/java/org/apache/accumulo/access/AuthorizationValidator.java#L107
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to