keith-turner commented on code in PR #6166:
URL: https://github.com/apache/accumulo/pull/6166#discussion_r2884379090
##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -600,7 +601,8 @@ private static void stopServers(final ServerContext
context, List<String> server
String managerLockPath = Constants.ZROOT + "/" + iid +
Constants.ZMANAGER_LOCK;
ZooZap.removeSingletonLock(zk, managerLockPath, hostAndPort::contains,
opts);
String gcLockPath = Constants.ZROOT + "/" + iid + Constants.ZGC_LOCK;
- ZooZap.removeSingletonLock(zk, gcLockPath, hostAndPort::contains,
opts);
+ ServiceLock.deleteLock(zk, gcLockPath,
ServerServices.Service.GC_CLIENT,
Review Comment:
This code will now log to debug where all the calls to ZooZap could
potentially print to stdout (by calling ZooZap message). So the GC behavior
for logging/printing will be different than all the other calls to
`ZooZap.removeSingletonLock` in this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
