ddanielr commented on code in PR #6166:
URL: https://github.com/apache/accumulo/pull/6166#discussion_r2885275998
##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -600,7 +601,8 @@ private static void stopServers(final ServerContext
context, List<String> server
String managerLockPath = Constants.ZROOT + "/" + iid +
Constants.ZMANAGER_LOCK;
ZooZap.removeSingletonLock(zk, managerLockPath, hostAndPort::contains,
opts);
String gcLockPath = Constants.ZROOT + "/" + iid + Constants.ZGC_LOCK;
- ZooZap.removeSingletonLock(zk, gcLockPath, hostAndPort::contains,
opts);
+ ServiceLock.deleteLock(zk, gcLockPath,
ServerServices.Service.GC_CLIENT,
Review Comment:
Looked into the logging a bit more and the Admin command can't actually have
zooZap print messages.
ZooZap's `message` only prints if `opts.verbose` is set to true.
https://github.com/apache/accumulo/blob/383c8027ab210004adf344964ae4b2ed841fdb16/server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java#L61-L65
By default verbose is set to false
https://github.com/apache/accumulo/blob/383c8027ab210004adf344964ae4b2ed841fdb16/server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java#L97-L98
The zooZap opts are created here and are not modified or added to the
jcommander object.
https://github.com/apache/accumulo/blob/33cf936b530e1c7d9115d4ec724aaaa8f7d2e83e/server/base/src/main/java/org/apache/accumulo/server/util/Admin.java#L588
So I don't think there's a way for the admin command to get ZooZap's lock
removals to print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
