ctubbsii commented on code in PR #6175:
URL: https://github.com/apache/accumulo/pull/6175#discussion_r2886296066
##########
assemble/bin/accumulo:
##########
@@ -34,6 +34,9 @@ function main() {
export conf="${ACCUMULO_CONF_DIR:-${basedir}/conf}"
export lib="${basedir}/lib"
export cmd="$1"
+ if [[ $cmd == "proc" ]]; then
+ cmd="$2"
+ fi
Review Comment:
This will work, but we should phase out this apparent "API" between the
bin/accumulo and conf/accumulo-env.sh scripts. Phasing out this "API" between
the scripts was the basis for the comment on line 52 regarding ACCUMULO_HOME
and ACCUMULO_CONF_DIR, yet these new variables (basedir, conf, lib, cmd, bin)
were added to replace them. However, these scripts really should be making
independent decisions, and bin/accumulo needs to do less.
For cmd, it would be better for the entire command line to be passed to the
accumulo-env.sh script, for it to make independent decisions about the
environment based on the full command line.
For example:
```bash
source "$conf/accumulo-env.sh" "$@"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
