keith-turner commented on code in PR #6175:
URL: https://github.com/apache/accumulo/pull/6175#discussion_r2886917429
##########
assemble/bin/accumulo:
##########
@@ -34,6 +34,9 @@ function main() {
export conf="${ACCUMULO_CONF_DIR:-${basedir}/conf}"
export lib="${basedir}/lib"
export cmd="$1"
+ if [[ $cmd == "proc" ]]; then
+ cmd="$2"
+ fi
Review Comment:
Looking at the way it works now not sure everything its using could be
derived from the command line. Like the `lib`,`bin`, and `conf` variables.
The default accumulo-env.sh builds the native libs using the `bin` variable, it
probably should not be doing that. So we probably do not need the `bin`
variable. The `lib` and `bin` dirs are used for classpath construction, how
would that be handled? The `cmd` variable probably could be derived from the
command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
