keith-turner commented on code in PR #115:
URL: https://github.com/apache/accumulo-access/pull/115#discussion_r2941800339
##########
modules/core/src/main/java/org/apache/accumulo/access/impl/AccessImpl.java:
##########
@@ -39,6 +39,12 @@ public class AccessImpl implements Access {
private final AuthorizationValidator authValidator;
+ private Set<String> validateAuthSet(Set<String> auths) {
+ var validated = Set.copyOf(auths);
Review Comment:
Could avoid this set copy by pushing validation into AccessEvaluatorImpl
after it has created a copy of the set. That way its still validating what is
being used, but only one set copy is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]