ctubbsii commented on code in PR #115:
URL: https://github.com/apache/accumulo-access/pull/115#discussion_r2943078233
##########
modules/core/src/main/java/org/apache/accumulo/access/impl/AccessImpl.java:
##########
@@ -39,6 +39,12 @@ public class AccessImpl implements Access {
private final AuthorizationValidator authValidator;
+ private Set<String> validateAuthSet(Set<String> auths) {
+ var validated = Set.copyOf(auths);
Review Comment:
I thought of that, but then I'd have to increase the visibility of the
private validate method, which I was trying to limit exposure, just to make it
easier to reason about where these were being used. Using a set instead of a
concrete type means we have to be very careful to ensure we're passing around
validated auths, to ensure we had the same behavior as before the removal of
that type. I still may implement this suggestion, though. I'll give it a shot
and see what it looks like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
